Repository navigation
Fix - Expense - Missing "Hold" and "Delete expense" option when report has only one expense - #65692
Conversation
|
@FitseTLT I can reproduce a bug in our PR, on native. I can't in the main. Screen.Recording.2025-07-15.at.12.57.32.movI'll investigate later. Can you reproduce it? Thanks. |
…-exclude-deleted-iou
|
Can't reproduce it on the branch 2025-07-18.01-16-49.mp4 |
|
Great, it's working fine now on iOS, looks like merging main fixed it. I will continue with the checklist. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp65692_android_native.movAndroid: mWeb Chrome65692_android_web.moviOS: HybridApp65692_ios_native.moviOS: mWeb Safari65692_ios_web.movMacOS: Chrome / Safari65692_web_chrome.movMacOS: Desktop65692_web_desktop.mov |
brunovjk
left a comment
There was a problem hiding this comment.
LGTM. The type error is not linked to our PR.
…-exclude-deleted-iou
|
Type error fixed U can proceed @cead22 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cead22 in version: 9.1.84-1 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.84-4 🚀
|
Details
Fixed Issues
$ #64800
PROPOSAL: #64800 (comment)
Tests
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop